755723 - [ro] Searchplugin setup for Romanian Fennec

Status: VERIFIED FIXED

(Mozilla Localizations :: ro / Romanian, defect)

Description

[Axel Hecht [:Pike]]

Right now, the mobile/searchplugins directory is a random mess.

What searchplugins should we ship?

Once we know what's supposed to be in there, please submit a patch for review to implement that.

Comment 1

[Alexandru Szasz]

Hi Axel, right now, list.txt has the en-US defaults, which would be just fine, that's why they're there.

I don't know if I need to put in wikipedia-ro instead of wikipedia to get wikipedia in Romanian.
That's the only change I'd want to do.

Comment 2

[Raul Nicolae Malea]

This bug is resolved?

Comment 3

[Francesco Lodolo [:flod]]

Not really, but I'm not sure what's the current situation with Fennec and Romanian.
CCing Jeff for that.

For sure the folder is still a mess
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ro/file/cfd6014662d4/mobile/searchplugins

All .xml files except for wikipedia-ro.xml must be removed, since they're en-US searchplugins. And currently wikipedia-ro is not currently in use.

Comment 4

[Raul Nicolae Malea]

Mozilla continue to develop Fennec? Fennec is Firefox for Android?

Comment 5

[Axel Hecht [:Pike]]

Yes.

Raul, there's not really a big need to flag individuals as needinfo on just regular questions. Also, flod does know what he's doing, feel free to trust his comments.

Comment 6

[Raul Nicolae Malea]

Jeff, any news for this?

Comment 7

[Jeff Beatty [:gueroJeff]]

(In reply to Raul Malea from comment #6)
> Jeff, any news for this?

Hey Raul,

Fennes is Firefox for Android. We can get Romanian into the multi-locale APK as soon as it's ready. As flod mentioned above, there are some issues with the searchplugins directory that would need to be resolved before shipping. If they can be resolved and Fennec translated, tested, and signed-off in the next 6 weeks, we can add it into Firefox 25.

What are your thoughts, Raul?

Comment 8

[Raul Nicolae Malea]

I was resolved manually  this file.

http://tradu.softwareliber.ro/project.php?l=ro&p=46

For Fennec Aurora have only 285 untranslated files (https://l10n.mozilla.org/dashboard/compare?run=330806) . I think make signoff for Firefox 25 :)

BUT , I need Alex help to import new files in Narro project: http://tradu.softwareliber.ro/project.php?l=ro&p=46

Comment 9

[Francesco Lodolo [:flod]]

What do you mean it was resolved manually? Not sure what you're referring to.
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ro/file/9ff5b9b3f33a/mobile/searchplugins

If you want I can go on and clean up the current errors, then we can start talking about the searchplugins you want to ship with Firefox on Android.

P.S. for Fennec 25 it will be 448 strings, at this time. 285 are the strings you're missing for Fennec 24.

Comment 10

[Raul Nicolae Malea]

Resolved here: http://hg.mozilla.org/releases/l10n/mozilla-aurora/ro/rev/4ff3dd826da2

Please confirm if it is ok. Thanks.

Comment 11

[Francesco Lodolo [:flod]]

Raul, searchplugins (like region.properties) are special files. 

For the future: NEVER modify these files directly, provide a patch in the bug, have it reviewed and commit with a meaningful message referencing the bug and the reviewer (you did none of these).

This is the list of searchplugins currently used in Firefox for Android
* amazondotcom
* google
* twitter
* wikipedia

Do you want to use wikipedia-ro instead of the English one? Are you OK with the other searchplugins?

If so there are two changes that must be made:
* correct the plugin removing the description, which isn't used on Android
* fix the list of searchplugins (list.txt), replacing wikipedia with wikipedia-ro

Again: you need to provide these changes in a patch and ask for a review, don't commit them to the repository. If you have problems with the procedure, let us know and we'll try to help you.

https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

Comment 12

[Raul Nicolae Malea]

(In reply to Francesco Lodolo [:flod] from comment #11)
> Raul, searchplugins (like region.properties) are special files. 
> 
> For the future: NEVER modify these files directly, provide a patch in the
> bug, have it reviewed and commit with a meaningful message referencing the
> bug and the reviewer (you did none of these).
> 
> This is the list of searchplugins currently used in Firefox for Android
> * amazondotcom
> * google
> * twitter
> * wikipedia
> 
> Do you want to use wikipedia-ro instead of the English one? Are you OK with
> the other searchplugins?

Yes, I use wikipedia-ro. 

I need change ammazondotcom with yahoo romania http://ro.search.yahoo.com/

> 
> If so there are two changes that must be made:
> * correct the plugin removing the description, which isn't used on Android
> * fix the list of searchplugins (list.txt), replacing wikipedia with
> wikipedia-ro
> 
> Again: you need to provide these changes in a patch and ask for a review,
> don't commit them to the repository. If you have problems with the
> procedure, let us know and we'll try to help you.
> 
> https://developer.mozilla.org/en-US/docs/
> Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-
> in_for_me.3F

Sorry, but I not are developer and I don't know how to make a patch.

Comment 13

[Jeff Beatty [:gueroJeff]]

(In reply to Raul Malea from comment #12)
> (In reply to Francesco Lodolo [:flod] from comment #11)
> > Raul, searchplugins (like region.properties) are special files. 
> > 
> > For the future: NEVER modify these files directly, provide a patch in the
> > bug, have it reviewed and commit with a meaningful message referencing the
> > bug and the reviewer (you did none of these).
> > 
> > This is the list of searchplugins currently used in Firefox for Android
> > * amazondotcom
> > * google
> > * twitter
> > * wikipedia
> > 
> > Do you want to use wikipedia-ro instead of the English one? Are you OK with
> > the other searchplugins?
> 
> Yes, I use wikipedia-ro. 
> 
> I need change ammazondotcom with yahoo romania http://ro.search.yahoo.com/
> 
> > 
> > If so there are two changes that must be made:
> > * correct the plugin removing the description, which isn't used on Android
> > * fix the list of searchplugins (list.txt), replacing wikipedia with
> > wikipedia-ro
> > 
> > Again: you need to provide these changes in a patch and ask for a review,
> > don't commit them to the repository. If you have problems with the
> > procedure, let us know and we'll try to help you.
> > 
> > https://developer.mozilla.org/en-US/docs/
> > Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-
> > in_for_me.3F
> 
> Sorry, but I not are developer and I don't know how to make a patch.

Hey Raul,

I'm not a developer either, but this wiki page has helped me create patches when I need to. Hope it helps you! :-)

 https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

Comment 14

[Raul Nicolae Malea]

So:

hg qnew searchplugin-romanian-fennec


removing mobile/searchplugins/amazondotcom.xml
removing mobile/searchplugins/google.xml
removing mobile/searchplugins/twitter.xml
removing mobile/searchplugins/wikipedia.xml
removing mobile/searchplugins/yahoo.xml


?

I do not understanding if these is commands in terminal or lines in txt files?

Comment 15

[Francesco Lodolo [:flod]]

1) Clone your repository from mozilla-aurora
2) Do the changes you need to do to your files (change list.txt, change wikipedia-ro.xml, change yahoo.xml), just don't commit them. I don't understand your comment considering that you already removed those files.
3) Create the patch using the instructions on MDN
4) Attach the patch to this bug

If something is not clear, please ask for help on IRC (channel #l10n). If nobody of us is around, I'm sure other localizers will be able to help you.

Comment 16

[Raul Nicolae Malea]

Attachment: searchplugin-setup

My first patch!

Comment 17

[Jeff Beatty [:gueroJeff]]

Comment on attachment 785935 [details] [diff] [review]
searchplugin-setup

Hooray for first patches!! :-D

It looks good to me technically speaking, however, flod will also need to weigh in here. 

Congratulations!

Comment 18

[Raul Nicolae Malea]

Thanks Jeff! :)

Comment 19

[Francesco Lodolo [:flod]]

Comment on attachment 785935 [details] [diff] [review]
searchplugin-setup

Review of attachment 785935 [details] [diff] [review]:
-----------------------------------------------------------------

The procedure is correct but the patch is not good.

1. As explained, you need to remove the <description> line from wikipedia-ro.xml

2. More important: you can't add a searchplugin to list.txt if you don't add the correspondent XML file. If you add yahoo-ro.xml, you need a yahoo-ro.xml too (and I would go with yahoo-ro more than yahoo-romania). 
You can run "hg qpop -a" to remove all pending patches from your current queue before creating a new one. Create the .xml file, add it to Mercurial (hg add yahoo-ro.xml) and then recreate the patch.

For the searchplugin, you can use other locales as a guide, for example (remove the Description line, it's not needed on Android):
http://mxr.mozilla.org/l10n-mozilla-aurora/source/fr/mobile/searchplugins/yahoo-france.xml
http://mxr.mozilla.org/l10n-mozilla-aurora/source/pt-BR/mobile/searchplugins/yahoo-br.xml

Comment 20

[Raul Nicolae Malea]

Thanks Francesco. I try again.

Comment 21

[Raul Nicolae Malea]

Attachment: searchplugin

Second patch for searchplugin setup

Comment 22

[Raul Nicolae Malea]

I hope is now ok. :P Thank you for your patience.

Comment 23

[Francesco Lodolo [:flod]]

Comment on attachment 786214 [details] [diff] [review]
searchplugin

Review of attachment 786214 [details] [diff] [review]:
-----------------------------------------------------------------

Almost there :-)

::: mobile/searchplugins/yahoo-ro.xml
@@ +3,5 @@
> +   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
> +
> + <SearchPlugin xmlns="http://www.mozilla.org/2006/browser/search/">
> + <ShortName>Yahoo!</ShortName>
> + <Description>Căutare cu Yahoo!</Description>

Please remove the Description.

@@ +9,5 @@
> + <Image width="16" height="16">data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAYAAABzenr0AAAACXBIWXMAAAsTAAALEwEAmpwYAAAKT2lDQ1BQaG90b3Nob3AgSUNDIHByb2ZpbGUAAHjanVNnVFPpFj333vRCS4iAlEtvUhUIIFJCi4AUkSYqIQkQSoghodkVUcERRUUEG8igiAOOjoCMFVEsDIoK2AfkIaKOg6OIisr74Xuja9a89+bN/rXXPues852zzwfACAyWSDNRNYAMqUIeEeCDx8TG4eQuQIEKJHAAEAizZCFz/SMBAPh+PDwrIsAHvgABeNMLCADATZvAMByH/w/qQplcAYCEAcB0kThLCIAUAEB6jkKmAEBGAYCdmCZTAKAEAGDLY2LjAFAtAGAnf+bTAICd+Jl7AQBblCEVAaCRACATZYhEAGg7AKzPVopFAFgwABRmS8Q5ANgtADBJV2ZIALC3AMDOEAuyAAgMADBRiIUpAAR7AGDIIyN4AISZABRG8lc88SuuEOcqAAB4mbI8uSQ5RYFbCC1xB1dXLh4ozkkXKxQ2YQJhmkAuwnmZGTKBNA/g88wAAKCRFRHgg/P9eM4Ors7ONo62Dl8t6r8G/yJiYuP+5c+rcEAAAOF0ftH+LC+zGoA7BoBt/qIl7gRoXgugdfeLZrIPQLUAoOnaV/Nw+H48PEWhkLnZ2eXk5NhKxEJbYcpXff5nwl/AV/1s+X48/Pf14L7iJIEyXYFHBPjgwsz0TKUcz5IJhGLc5o9H/LcL//wd0yLESWK5WCoU41EScY5EmozzMqUiiUKSKcUl0v9k4t8s+wM+3zUAsGo+AXuRLahdYwP2SycQWHTA4vcAAPK7b8HUKAgDgGiD4c93/+8//UegJQCAZkmScQAAXkQkLlTKsz/HCAAARKCBKrBBG/TBGCzABhzBBdzBC/xgNoRCJMTCQhBCCmSAHHJgKayCQiiGzbAdKmAv1EAdNMBRaIaTcA4uwlW4Dj1wD/phCJ7BKLyBCQRByAgTYSHaiAFiilgjjggXmYX4IcFIBBKLJCDJiBRRIkuRNUgxUopUIFVIHfI9cgI5h1xGupE7yAAygvyGvEcxlIGyUT3UDLVDuag3GoRGogvQZHQxmo8WoJvQcrQaPYw2oefQq2gP2o8+Q8cwwOgYBzPEbDAuxsNCsTgsCZNjy7EirAyrxhqwVqwDu4n1Y8+xdwQSgUXACTYEd0IgYR5BSFhMWE7YSKggHCQ0EdoJNwkDhFHCJyKTqEu0JroR+cQYYjIxh1hILCPWEo8TLxB7iEPENyQSiUMyJ7mQAkmxpFTSEtJG0m5SI+ksqZs0SBojk8naZGuyBzmULCAryIXkneTD5DPkG+Qh8lsKnWJAcaT4U+IoUspqShnlEOU05QZlmDJBVaOaUt2ooVQRNY9aQq2htlKvUYeoEzR1mjnNgxZJS6WtopXTGmgXaPdpr+h0uhHdlR5Ol9BX0svpR+iX6AP0dwwNhhWDx4hnKBmbGAcYZxl3GK+YTKYZ04sZx1QwNzHrmOeZD5lvVVgqtip8FZHKCpVKlSaVGyovVKmqpqreqgtV81XLVI+pXlN9rkZVM1PjqQnUlqtVqp1Q61MbU2epO6iHqmeob1Q/pH5Z/YkGWcNMw09DpFGgsV/jvMYgC2MZs3gsIWsNq4Z1gTXEJrHN2Xx2KruY/R27iz2qqaE5QzNKM1ezUvOUZj8H45hx+Jx0TgnnKKeX836K3hTvKeIpG6Y0TLkxZVxrqpaXllirSKtRq0frvTau7aedpr1Fu1n7gQ5Bx0onXCdHZ4/OBZ3nU9lT3acKpxZNPTr1ri6qa6UbobtEd79up+6Ynr5egJ5Mb6feeb3n+hx9L/1U/W36p/VHDFgGswwkBtsMzhg8xTVxbzwdL8fb8VFDXcNAQ6VhlWGX4YSRudE8o9VGjUYPjGnGXOMk423GbcajJgYmISZLTepN7ppSTbmmKaY7TDtMx83MzaLN1pk1mz0x1zLnm+eb15vft2BaeFostqi2uGVJsuRaplnutrxuhVo5WaVYVVpds0atna0l1rutu6cRp7lOk06rntZnw7Dxtsm2qbcZsOXYBtuutm22fWFnYhdnt8Wuw+6TvZN9un2N/T0HDYfZDqsdWh1+c7RyFDpWOt6azpzuP33F9JbpL2dYzxDP2DPjthPLKcRpnVOb00dnF2e5c4PziIuJS4LLLpc+Lpsbxt3IveRKdPVxXeF60vWdm7Obwu2o26/uNu5p7ofcn8w0nymeWTNz0MPIQ+BR5dE/C5+VMGvfrH5PQ0+BZ7XnIy9jL5FXrdewt6V3qvdh7xc+9j5yn+M+4zw33jLeWV/MN8C3yLfLT8Nvnl+F30N/I/9k/3r/0QCngCUBZwOJgUGBWwL7+Hp8Ib+OPzrbZfay2e1BjKC5QRVBj4KtguXBrSFoyOyQrSH355jOkc5pDoVQfujW0Adh5mGLw34MJ4WHhVeGP45wiFga0TGXNXfR3ENz30T6RJZE3ptnMU85ry1KNSo+qi5qPNo3ujS6P8YuZlnM1VidWElsSxw5LiquNm5svt/87fOH4p3iC+N7F5gvyF1weaHOwvSFpxapLhIsOpZATIhOOJTwQRAqqBaMJfITdyWOCnnCHcJnIi/RNtGI2ENcKh5O8kgqTXqS7JG8NXkkxTOlLOW5hCepkLxMDUzdmzqeFpp2IG0yPTq9MYOSkZBxQqohTZO2Z+pn5mZ2y6xlhbL+xW6Lty8elQfJa7OQrAVZLQq2QqboVFoo1yoHsmdlV2a/zYnKOZarnivN7cyzytuQN5zvn//tEsIS4ZK2pYZLVy0dWOa9rGo5sjxxedsK4xUFK4ZWBqw8uIq2Km3VT6vtV5eufr0mek1rgV7ByoLBtQFr6wtVCuWFfevc1+1dT1gvWd+1YfqGnRs+FYmKrhTbF5cVf9go3HjlG4dvyr+Z3JS0qavEuWTPZtJm6ebeLZ5bDpaql+aXDm4N2dq0Dd9WtO319kXbL5fNKNu7g7ZDuaO/PLi8ZafJzs07P1SkVPRU+lQ27tLdtWHX+G7R7ht7vPY07NXbW7z3/T7JvttVAVVN1WbVZftJ+7P3P66Jqun4lvttXa1ObXHtxwPSA/0HIw6217nU1R3SPVRSj9Yr60cOxx++/p3vdy0NNg1VjZzG4iNwRHnk6fcJ3/ceDTradox7rOEH0x92HWcdL2pCmvKaRptTmvtbYlu6T8w+0dbq3nr8R9sfD5w0PFl5SvNUyWna6YLTk2fyz4ydlZ19fi753GDborZ752PO32oPb++6EHTh0kX/i+c7vDvOXPK4dPKy2+UTV7hXmq86X23qdOo8/pPTT8e7nLuarrlca7nuer21e2b36RueN87d9L158Rb/1tWeOT3dvfN6b/fF9/XfFt1+cif9zsu72Xcn7q28T7xf9EDtQdlD3YfVP1v+3Njv3H9qwHeg89HcR/cGhYPP/pH1jw9DBY+Zj8uGDYbrnjg+OTniP3L96fynQ89kzyaeF/6i/suuFxYvfvjV69fO0ZjRoZfyl5O/bXyl/erA6xmv28bCxh6+yXgzMV70VvvtwXfcdx3vo98PT+R8IH8o/2j5sfVT0Kf7kxmTk/8EA5jz/GMzLdsAAAAgY0hSTQAAeiUAAICDAAD5/wAAgOkAAHUwAADqYAAAOpgAABdvkl/FRgAAA7xJREFUeNrs10tslFUUB/DfN9NCaUsir2JAQAQKBgQXiFEeC6JdKAQCoiERXKiJrmRhNMZH3LjQjaILIiqKCWp8BgL4IGpQWkASCY+qWHm0CFjKyz5oO9PO56LfDNNhpmXHwp7ky9w5c+49//ud//nfO0EYhq6nxVxnGwAwAOC6Ayh6IVjfX8wEzMBMlCDdt2fwM+rR1s8a03AIR3AAv+EYGov6mLQKq3FPP4s34AN8gt8LxAxBEaZHT9rq85XgiWh3H15DchiPl6JdfRQly7XLBebuyAXwBdaFwhtTQt1SmSclFOpXNVeiCVNy/Mk8sQfweTaAT7GsZxhkEnfp1qVbiFAQffZpZVEpKrJ8+absQU2aAw9hRUpK+YhSyzbOVzFjpNbGNsnWpGRnShjS3NBq85PVOiV6vY1AICZQrEhMAHFsxZwoJJEHwHdoKcJ9eDG9UKIlac+6WsMm3mDJW/My0V89+pOTv5zVrsOtd08wbu5o7Rc7BAFDRpQoLok7uOmoprpLYj3dfQfmYRdO5QGwTcTMx9LMDASSiS4Htx3XptPx7aetOfogqFw81jcb9goQL467ac4otz0wCbQ2tavffcb+9+tyebIiApBr9ehMC9G07F8CgVKDDVeu7thJG6u2g+lLJ1n+zAKdkqp31jq1r6lnG0/XeLniPeuXbHG+vkVcPHu5+QV4sjUjREjll8iYcqV27zhs5FPD3L/2LlWv3qnx4L9mrp5o1sop1s/d7EDNX8qUKjeop/q9bWgBAN9nA8grRgHiYsqV+fbNPW5eONr0JbdY9XWVjpaE1yo2aWg6a6gy8TT1rr3/f80+C+oK9VMgUCQmqcsPz+3P+Lc8vsuRpgalSsQKJ4fdeXx/RxzIAHgHfxR6CyG6hVKJ7oy//VynpJSUVF/J4bM8vkO9DiNswbBIz3tZKFQSG2TS+DEql4/L+CcvGisRT2qua3PheHME9So7nF1rjI5a88/soPgCi9OyOBuVvfUzZczM4R7+ssrY2aOc3n/OxRPNSkeWmHrveJdOtvin9mKhIsxGc9Z4MKpxIYugYfC8t3PPgmW9uiGIKR5SpP1yQjKS9Jj4Fc272lJYiJ1ZvjpMjsYfoxaz8G5uByzHGryeWS1M6bjcGdUrniFnDzuCfOr2CM5n+QZlJYdGvNLXjeiNaOVnsRfJtNbHxcQj3gdXkp/AhkhNF+UkF11ifkRr9L06l4SFbC32YWmk6eOyRCtAC2qiW9HW6A6Rz5qjs+Z2TM3tuGDgn9EAgP89gP8GAF3DLhLnfG5QAAAAAElFTkSuQmCC</Image>
> + <Url type="text/html" method="GET" template="http://ro.search.yahoo.com/search">
> + <Param name="p" value="{searchTerms}"/>
> + <Param name="ei" value="UTF-8"/>
> + <MozParam name="ro" condition="pref" pref="yahoo-ro" />

This line must remain

<MozParam name="fr" condition="pref" pref="yahoo-fr" />

That's why I gave you also the example of pt-BR (fr could have been misleading) ;-)
See also the English searchplugin
http://hg.mozilla.org/mozilla-central/file/a0dd80f800e2/mobile/locales/en-US/searchplugins/yahoo.xml

Comment 24

[Francesco Lodolo [:flod]]

To answer your question about committing the changes once the patch has been reviewed. 

1. From inside mozilla-aurora import the patch, adapt the path to the real patch file
hg import --no-commit searchplugin.patch

2. Commit with a meaningful message. Example
hg commit -m "Bug 755723 - [ro] Searchplugin setup for Romanian Fennec, r=flod"

3. Push changes to mozilla-aurora 
hg push

Comment 25

[Raul Nicolae Malea]

Attachment: searchplugin-patch

Corrected patch for searchplugin setup Romanian Fennec

Comment 26

[Jeff Beatty [:gueroJeff]]

(In reply to Raul Malea from comment #12)
> (In reply to Francesco Lodolo [:flod] from comment #11)
> > Raul, searchplugins (like region.properties) are special files. 
> > 
> > For the future: NEVER modify these files directly, provide a patch in the
> > bug, have it reviewed and commit with a meaningful message referencing the
> > bug and the reviewer (you did none of these).
> > 
> > This is the list of searchplugins currently used in Firefox for Android
> > * amazondotcom
> > * google
> > * twitter
> > * wikipedia
> > 
> > Do you want to use wikipedia-ro instead of the English one? Are you OK with
> > the other searchplugins?
> 
> Yes, I use wikipedia-ro. 
> 
> I need change ammazondotcom with yahoo romania http://ro.search.yahoo.com/
> 
> > 
> > If so there are two changes that must be made:
> > * correct the plugin removing the description, which isn't used on Android
> > * fix the list of searchplugins (list.txt), replacing wikipedia with
> > wikipedia-ro
> > 
> > Again: you need to provide these changes in a patch and ask for a review,
> > don't commit them to the repository. If you have problems with the
> > procedure, let us know and we'll try to help you.
> > 
> > https://developer.mozilla.org/en-US/docs/
> > Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-
> > in_for_me.3F
> 
> Sorry, but I not are developer and I don't know how to make a patch.

Hey Raul,

Could you give some more information behind this change? Amazon is there to provide users with an e-commerce option through which they can make purchases online. If Amazon is not the most appropriate e-commerce option, is there another that is more widely used? Why would Yahoo! be a good replacement for Amazon?

Thanks,
Jeff

Comment 27

[Raul Nicolae Malea]

> > 
> > I need change ammazondotcom with yahoo romania http://ro.search.yahoo.com/
> > 
> > > 
> > > If so there are two changes that must be made:
> > > * correct the plugin removing the description, which isn't used on Android
> > > * fix the list of searchplugins (list.txt), replacing wikipedia with
> > > wikipedia-ro
> > > 

> > 
> > Sorry, but I not are developer and I don't know how to make a patch.
> 
> Hey Raul,
> 
> Could you give some more information behind this change? Amazon is there to
> provide users with an e-commerce option through which they can make
> purchases online. If Amazon is not the most appropriate e-commerce option,
> is there another that is more widely used? Why would Yahoo! be a good
> replacement for Amazon?
> 
> Thanks,
> Jeff

Oh, it is a small problem. If is necessary e-commerce search provider so I prefer use e-bay for Romanian users (because (in romanian): http://www.zoso.ro/foto-okazii-ebay/ and http://tudorgalos.ro/2012/04/de-ce-nu-livreaza-amazon-in-romania/ ).

Perhaps this situation is similar to France (http://mxr.mozilla.org/l10n-mozilla-aurora/source/fr/mobile/searchplugins/).  

Need to add other e-commerce search provider (e-Bay in this case)?

Yahoo is other search engine used in Romania after Google.

Comment 28

[Francesco Lodolo [:flod]]

Comment on attachment 786230 [details] [diff] [review]
searchplugin-patch

Review of attachment 786230 [details] [diff] [review]:
-----------------------------------------------------------------

As discussed on IRC, we need an ecommerce searchplugin, so we'll use eBay instead of Amazon and drop Yahoo! from the current patch.

Comment 29

[Raul Nicolae Malea]

Attachment: searchplugin-patch

New patch by IRC conversation.

Comment 30

[Francesco Lodolo [:flod]]

Joanne, we're trying to setup eBay as a searchplugin for Romanian on Firefox Android. 

Can you tell me if this URL is correct? 
http://rover.ebay.com/rover/1/709-47295-17703-3/4

Comment 31

[Raul Nicolae Malea]

Damn! Not! :) This link go to into French version. Correct link is: http://www.ebay.com/sch/allcategories/all-categories/?_rdc=1

But I don't know how transform this in rover link. :P

Comment 32

[Francesco Lodolo [:flod]]

Yep, the link is definitely wrong. I don't think that eBay is available in Romanian, so we should fallback to en-US?

Comment 33

[Raul Nicolae Malea]

(In reply to Francesco Lodolo [:flod] from comment #32)
> Yep, the link is definitely wrong. I don't think that eBay is available in
> Romanian, so we should fallback to en-US?

Yes.

Comment 34

[Joanne Nagel]

Do you guys still want me to check with eBay on their preference or are you sticking with en-US?

Comment 35

[Francesco Lodolo [:flod]]

I think checking would be better. 

Firefox for Android is not currently using eBay for en-US, the only reference I have is http://rover.ebay.com/rover/1/711-47294-18009-3/4 used on the desktop search engine.

Comment 36

[Raul Nicolae Malea]

(In reply to Francesco Lodolo [:flod] from comment #35)
> I think checking would be better. 
> 
> Firefox for Android is not currently using eBay for en-US, the only
> reference I have is http://rover.ebay.com/rover/1/711-47294-18009-3/4 used
> on the desktop search engine.

This is correct link for Romanian, in my opinion. Please confirm and review my patch again :P . Thanks.

Comment 37

[Raul Nicolae Malea]

Joanne, what links is correct?

Comment 38

[Raul Nicolae Malea]

I try commited other translation for Aurora but: 

abort: cannot commit over an applied mq patch

Need deleted patch?

Comment 39

[Francesco Lodolo [:flod]]

Empty the curremt queue ("hg qpop -a" should work) and then pay attention to not commit changes involving searchplugins when you push yout changes, fot example by checking the output of "hg status" before the commit.

Comment 40

[Francesco Lodolo [:flod]]

(In reply to Francesco Lodolo [:flod] from comment #35)
> I think checking would be better. 
> 
> Firefox for Android is not currently using eBay for en-US, the only
> reference I have is http://rover.ebay.com/rover/1/711-47294-18009-3/4 used
> on the desktop search engine.

Reflagging Joanne to be sure she sees this.

Comment 41

[Francesco Lodolo [:flod]]

Comment on attachment 786425 [details] [diff] [review]
searchplugin-patch

Review of attachment 786425 [details] [diff] [review]:
-----------------------------------------------------------------

Let's r- this while we wait for the right URL to use.

Comment 42

[Raul Nicolae Malea]

Joanne, this link is correct or no? Thank you!

Comment 43

[Joanne Nagel]

I sent a request to eBay - my contact says they have a mobile site:  m.ebay.com  As for Romania, she was waiting for their PM to respond and I have not received an update.

Comment 44

[Raul Nicolae Malea]

I think link http://rover.ebay.com/rover/1/711-47294-18009-3/4 are correct (english version). For French have:http://rover.ebay.com/rover/1/709-47295-17703-3/4 (aka http://www.ebay.fr/sch/allcategories/all-categories/?_rdc=1 - desktop version) 

eBay not have romanian version yet.

Comment 45

[Raul Nicolae Malea]

Attachment: searchplugin-ro

New patch with English link version for eBay

Comment 46

[Francesco Lodolo [:flod]]

As explained in comment 43, we're waiting for a reply from eBay, so please be a little more patient. I'll leave the r? open for now.

Comment 47

[Raul Nicolae Malea]

Ok, Francesco. Thanks.

Comment 48

[Raul Nicolae Malea]

One small question: Now, I have two patch pending. This patch and patch for bug 899203. Is a problem? As you proceed? Sending both with one procedure?

Comment 49

[Francesco Lodolo [:flod]]

You can empty the queue and import the file you attached to Bugzilla for commit.

Comment 50

[Raul Nicolae Malea]

Joanne, any news? I need implementation this patch before signoff for FX25 :) Thanks.

Comment 51

[Joanne Nagel]

No, I even nudged my counterpart again this week...no update.

Comment 52

[Raul Nicolae Malea]

I kindly ask you if it is possible to fix this bug before signoff for version 25 in next week. Thank you.

Comment 53

[Raul Nicolae Malea]

Francesco, please reviewed my patch with actual link. If link is not corrected, reopening this bug and implementing in fx26.

Comment 54

[Francesco Lodolo [:flod]]

Comment on attachment 791737 [details] [diff] [review]
searchplugin-ro

Review of attachment 791737 [details] [diff] [review]:
-----------------------------------------------------------------

Unfortunately we can't go on with eBay's searchplugin without further information from them.

Please provide a patch that removes Amazon and adds wikipedia-ro and yahoo-ro, I'll try to review it as soon as possible. 
Then we'll open a new follow-up bug just to add eBay.

Comment 55

[Raul Nicolae Malea]

Attachment: searchplugin

Final patch for this bug.
eBay added in future in version 26, after know correct link.

Comment 56

[Francesco Lodolo [:flod]]

Comment on attachment 799554 [details] [diff] [review]
searchplugin

Review of attachment 799554 [details] [diff] [review]:
-----------------------------------------------------------------

The Yahoo! icon is not showing up, I've also tried locally with a HTML page and the data URI provided but it's displayed as a missing image.

Where does that data URI come from? Unfortunately I can find only 16px favicons around.

Comment 57

[Francesco Lodolo [:flod]]

Attachment: favicon_32px.png

Found out that favicon.ico has also the 32px version. You can use a website like this one to get the data URI from the png icon.
http://webcodertools.com/imagetobase64converter

Comment 58

[Raul Nicolae Malea]

Image tag: <img alt="" src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAYAAABzenr0AAAEJGlDQ1BJQ0MgUHJvZmlsZQAAOBGFVd9v21QUPolvUqQWPyBYR4eKxa9VU1u5GxqtxgZJk6XtShal6dgqJOQ6N4mpGwfb6baqT3uBNwb8AUDZAw9IPCENBmJ72fbAtElThyqqSUh76MQPISbtBVXhu3ZiJ1PEXPX6yznfOec7517bRD1fabWaGVWIlquunc8klZOnFpSeTYrSs9RLA9Sr6U4tkcvNEi7BFffO6+EdigjL7ZHu/k72I796i9zRiSJPwG4VHX0Z+AxRzNRrtksUvwf7+Gm3BtzzHPDTNgQCqwKXfZwSeNHHJz1OIT8JjtAq6xWtCLwGPLzYZi+3YV8DGMiT4VVuG7oiZpGzrZJhcs/hL49xtzH/Dy6bdfTsXYNY+5yluWO4D4neK/ZUvok/17X0HPBLsF+vuUlhfwX4j/rSfAJ4H1H0qZJ9dN7nR19frRTeBt4Fe9FwpwtN+2p1MXscGLHR9SXrmMgjONd1ZxKzpBeA71b4tNhj6JGoyFNp4GHgwUp9qplfmnFW5oTdy7NamcwCI49kv6fN5IAHgD+0rbyoBc3SOjczohbyS1drbq6pQdqumllRC/0ymTtej8gpbbuVwpQfyw66dqEZyxZKxtHpJn+tZnpnEdrYBbueF9qQn93S7HQGGHnYP7w6L+YGHNtd1FJitqPAR+hERCNOFi1i1alKO6RQnjKUxL1GNjwlMsiEhcPLYTEiT9ISbN15OY/jx4SMshe9LaJRpTvHr3C/ybFYP1PZAfwfYrPsMBtnE6SwN9ib7AhLwTrBDgUKcm06FSrTfSj187xPdVQWOk5Q8vxAfSiIUc7Z7xr6zY/+hpqwSyv0I0/QMTRb7RMgBxNodTfSPqdraz/sDjzKBrv4zu2+a2t0/HHzjd2Lbcc2sG7GtsL42K+xLfxtUgI7YHqKlqHK8HbCCXgjHT1cAdMlDetv4FnQ2lLasaOl6vmB0CMmwT/IPszSueHQqv6i/qluqF+oF9TfO2qEGTumJH0qfSv9KH0nfS/9TIp0Wboi/SRdlb6RLgU5u++9nyXYe69fYRPdil1o1WufNSdTTsp75BfllPy8/LI8G7AUuV8ek6fkvfDsCfbNDP0dvRh0CrNqTbV7LfEEGDQPJQadBtfGVMWEq3QWWdufk6ZSNsjG2PQjp3ZcnOWWing6noonSInvi0/Ex+IzAreevPhe+CawpgP1/pMTMDo64G0sTCXIM+KdOnFWRfQKdJvQzV1+Bt8OokmrdtY2yhVX2a+qrykJfMq4Ml3VR4cVzTQVz+UoNne4vcKLoyS+gyKO6EHe+75Fdt0Mbe5bRIf/wjvrVmhbqBN97RD1vxrahvBOfOYzoosH9bq94uejSOQGkVM6sN/7HelL4t10t9F4gPdVzydEOx83Gv+uNxo7XyL/FtFl8z9ZAHF4bBsrEwAAAAlwSFlzAAALEwAACxMBAJqcGAAAA0VJREFUWAntV11IFFEUPvfOiEGl+xIJhayoBBaxQr2EkfoQS2WtIBL0oBI+FIVJuQgRuhQk64NC4IsPSeFLBP4hiRAqWE+RWhGGLTtYYUv74CpJ0uy9zbl6h9lpXAcRfNkLzj3nu+ee880959xZCecc9nLQvQyOsTMEMiegbleEVcUd5YwrXsq512rLCNEoSWojC62TVnwruaqoc8Jc43xKyJRNEqc2vFwQDnAF6gihAXNTGoFzNsiADI1+benbygwJEELK7espBPBtgSldhBKf3dCVzrnGSbLB6VScCBgvP2kW4cWiznoC6sSOgyNDQrzoo6ow3O6S8JQggMEVQp662uTCiFDa5ooE1oDf+9ibpSgzBnsP+i7zl8D52hOOYb5+jMGzro36cTSwgUmdl45GW2YRdkrB8MI9omZR2iSDo+H8zDeIL63A8VNHoa61DCFYTfyBh9cHYX7uu9CR5OEjOUK2PqJffsH76YgJKQprMpQGE7AImH9UVSN4wIJDPLYq/jBY7McKBJ9cgIO5+6CyusQkgPb7c7Kh5uZpsXVhLgZzbxYN4gmrK6MmlHoDcCQAm61IsXAMI8cxPfYZxvo/iDX/tZMiPaggfiA3W+A991/D3ZrnIjWLkbjArA/RWVZAykb+Udz2IuppH4e8fA/4zubDjUeVIj2NDyogz5sLt/x94BRUxkg3y1Y12zCdccftIVjSEiIV4ZdXhWnjud4dB5f5R0fUyIUmPKZ5rP1eh4Hed6ZFf/dbQMzNkG+aYiuvYgM0TmAjFykGDopmVLgca6vuguMVLfdYZ8aIiat/kzyUpfCAtRWtxlLGtpTDe+yQEOM/E6JjJG6fWZKEJMaS0ExV3cMZ9Y1Gg+JuwDXxLUh3E/prS+GMv1j6SZnHX3wSHZECbiqcsdBIJNiOanVByKOr2T5dB+1VtFVDTA7zY5SOhDR2PTPWPRwJNkv7S4XhO5TSLqlz0CtkbZhdgJ9SXHBTlNLRfzMWtM6qrcHRhgB4rLaqvm6mIOUe2GRVgKdhtMeV3fw9YCUwEG1blrqZAgnYZ7zJsHDsb2H8N7FMKJvFt7E6tO+36+hPHj+ubUvA7mC3dbMGdtuxW38ZApkT2PMT+AeXIljKg+rnQAAAAABJRU5ErkJggg==" />

Comment 59

[Francesco Lodolo [:flod]]

This will work, but you need to create a new patch.

Comment 60

[Raul Nicolae Malea]

Attachment: searchpluginro

Patch with correct link data for yahoo icon

Comment 61

[Francesco Lodolo [:flod]]

Comment on attachment 800261 [details] [diff] [review]
searchpluginro

Review of attachment 800261 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/searchplugins/yahoo-ro.xml
@@ +3,5 @@
> +  - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
> +<SearchPlugin xmlns="http://www.mozilla.org/2006/browser/search/">
> +<ShortName>Yahoo!</ShortName>
> +<InputEncoding>UTF-8</InputEncoding>
> +<Image width="32" 

Exactly like the Wikipedia plugin, icon must be 32px, but width and height must remain set to 16 (the data URI this time is correct).

I thought I already wrote that in the bug, but apparently I did in other bugs :-(

One more iteration and we should be good to go.

Comment 62

[Francesco Lodolo [:flod]]

Note that both height and width must be 16, and remove the new line between them (keep them on one line).

Comment 63

[Francesco Lodolo [:flod]]

This bug is definitely unlucky. Yahoo! just rolled out a new logo and completely different favicon.
http://www.yahoo.com/favicon.ico

At this point I'm going to provide a new patch and ask directly Axel for review.

Comment 64

[Francesco Lodolo [:flod]]

Attachment: New Yahoo! favicon (32px)

Comment 65

[Francesco Lodolo [:flod]]

Attachment: Updated patch (new icon)

This patch: 
* removes amazondotcom and wikipedia from list.txt
* adds wikipedia-ro and yahoo-ro

Some notes about yahoo-ro:
* it's using the new icon
* it's based on the current plugin used by French

Yahoo has a mobile website (http://m.search.yahoo.com/ and http://m.yahoo.com/) but it doesn't seems to be localized.

Both plugins can be tested here: http://flod.org/testsp

Comment 66

[Raul Nicolae Malea]

(In reply to Francesco Lodolo [:flod] from comment #65)
> Created attachment 800681 [details] [diff] [review]
> Updated patch (new icon)
> 
> This patch: 
> * removes amazondotcom and wikipedia from list.txt
> * adds wikipedia-ro and yahoo-ro
> 
> Some notes about yahoo-ro:
> * it's using the new icon
> * it's based on the current plugin used by French
> 
> Yahoo has a mobile website (http://m.search.yahoo.com/ and
> http://m.yahoo.com/) but it doesn't seems to be localized.
> 
> Both plugins can be tested here: http://flod.org/testsp

Thank you Francesco! In my opinion your patch is good. Yes, this bug is unlucky for me :(

http://m.yahoo.com/ are localized in Romanian default for me (http://m.yahoo.com/w/ulm%3B_ylt=A2KL8xYz0SlSm1IAmAQp89w4?r=%2F&.ysid=oiTjw9sk8aVP0VUXAdsZVxAs&.intl=RO&.lang=ro)

Comment 67

[Axel Hecht [:Pike]]

Comment on attachment 800681 [details] [diff] [review]
Updated patch (new icon)

Review of attachment 800681 [details] [diff] [review]:
-----------------------------------------------------------------

We shouldn't add yahoo until we know which. Also, I just started to ask about the new yahoo logo in another bug.

For now, let's remove both yahoo and amanzon, and put yahoo into a follow-up bug.

::: mobile/searchplugins/list.txt
@@ +1,4 @@
>  google
>  twitter
> +wikipedia-ro
> +yahoo-ro

No yahoo until we know what we're doing, please.

Comment 68

[Francesco Lodolo [:flod]]

Attachment: bug755723v2.patch

Based on IRC discussion, this patch only removes amazon and replace wikipedia with wikipedia-ro (the file is already in the repository). No changes to wikipedia-ro (i.e. not removing the description).

Comment 69

[Raul Nicolae Malea]

Thanks again Francesco. 

So, for ebay and yahoo-ro need to opened another bug after obtains more informations?

Comment 70

[Francesco Lodolo [:flod]]

I'll open the bugs as soon as we manage to fix this one.

Comment 71

[Raul Nicolae Malea]

Thank you Axel. Francesco, implementing this patch for fx25 or for fx26?

Comment 72

[Francesco Lodolo [:flod]]

Land it on mozilla-aurora (don't forget references to bug and r+ in the commit message), I'd say we'll discuss it for fx26 (next cycle on aurora).

Comment 73

[Jeff Beatty [:gueroJeff]]

(In reply to Raul Malea from comment #71)
> Thank you Axel. Francesco, implementing this patch for fx25 or for fx26?

Raul, you should be able to land your patch in Aurora now. I would recommend cancelling your current sign off for Fennec Aurora, landing this patch, and then resubmitting once the changeset appears on the dashboard. I'll watch for the new sign off to help push it through to approval today. Since all of your translation work is complete, I see no reason why this can't be added to 25 this cycle.

Comment 74

[Raul Nicolae Malea]

Ok Francesco. I need import this patch in my local clone of aurora?

Comment 75

[Raul Nicolae Malea]

Finally this bug is resolved: http://hg.mozilla.org/releases/l10n/mozilla-aurora/ro/rev/cdbf50ab417c 

Hooray! :)

Also for ebay and yahoo-ro I need opened new bug for implementing in fx26.
Thank you all.

Comment 76

[Raul Nicolae Malea]

Verified in Aurora /rev/24fe7575387d